----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14626/#review60486 -----------------------------------------------------------
Looks good, Varun, just some simple re-thinking of the REST API update handles that you added. I think we can make them more RESTful with my comments. Also this would be good to then update or add to this wiki page the new end points you're adding: https://cwiki.apache.org/confluence/display/OODT/CAS+Curator+REST+API We're close and thank you! - Chris Mattmann On Nov. 7, 2014, 10:13 p.m., Varun Ratnakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14626/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 10:13 p.m.) > > > Review request for oodt and Chris Mattmann. > > > Bugs: OODT-562 > https://issues.apache.org/jira/browse/OODT-562 > > > Repository: oodt > > > Description > ------- > > This patch is for https://issues.apache.org/jira/browse/OODT-562 > > 1. It adds some functions to the cas-curator's Metadata service > 2. Added functions to the file-manager in XMLValidationLayer for > adding/removing/retrieving parents of product types) > > > Diffs > ----- > > > trunk/curator/src/main/java/org/apache/oodt/cas/curation/service/MetadataResource.java > 1636677 > > trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/util/XmlStructFactory.java > 1636677 > > trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/validation/XMLValidationLayer.java > 1636677 > > Diff: https://reviews.apache.org/r/14626/diff/ > > > Testing > ------- > > > Thanks, > > Varun Ratnakar > >
