----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37701/#review96361 -----------------------------------------------------------
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/AvroCrawlDaemon.java (line 1) <https://reviews.apache.org/r/37701/#comment151679> I wonder if this could be refactored, so that the differences between it and XmlRpc one are minimal. trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/AvroCrawlDaemonController.java (line 33) <https://reviews.apache.org/r/37701/#comment151681> also maybe refactor to create minor differences between this and XmlRpc one. trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/CrawlDaemonController.java (line 42) <https://reviews.apache.org/r/37701/#comment151686> How about just change CrawlDaemonController to an interface instead of changing its name? trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/IntCrawlDaemon.java (line 24) <https://reviews.apache.org/r/37701/#comment151687> maybe just call it CrawlDaemon and then CrawlDaemonController? trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/IntCrawlDaemonController.java (line 24) <https://reviews.apache.org/r/37701/#comment151688> take the Int prefix off? - Chris Mattmann On Aug. 22, 2015, 3:50 p.m., Radu Manole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37701/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2015, 3:50 p.m.) > > > Review request for oodt, Lewis McGibbney and Chris Mattmann. > > > Repository: oodt > > > Description > ------- > > Modified the DaemonCrawler to use Avro RPC login instead of XML-RPC. > > > Diffs > ----- > > trunk/crawler/pom.xml 1693501 > trunk/crawler/src/main/avro/types/protocol.avdl PRE-CREATION > trunk/crawler/src/main/bin/crawlctl 1693501 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/action/CrawlerLauncherCliAction.java > 1693501 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/AvroCrawlDaemon.java > PRE-CREATION > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/AvroCrawlDaemonController.java > PRE-CREATION > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/CrawlDaemon.java > 1693501 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/CrawlDaemonController.java > 1693501 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/IntCrawlDaemon.java > PRE-CREATION > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/IntCrawlDaemonController.java > PRE-CREATION > > trunk/crawler/src/test/java/org/apache/oodt/cas/crawl/daemon/DummyDaemonCrawler.java > PRE-CREATION > > trunk/crawler/src/test/java/org/apache/oodt/cas/crawl/daemon/TestDaemonCrawler.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37701/diff/ > > > Testing > ------- > > No test was found for xmlrpc DaemonCrawler logic, so I made a > DummyAvroDaemonCrawler class to test only the rpc aspect of daemon crawler. > and created a class TestDaemonCrawler where I tested the connection and the > communication between AvroDaemonCrawler and AvroDaemonCrawlerController. > > > Thanks, > > Radu Manole > >
