[ https://issues.apache.org/jira/browse/OODT-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528802#comment-16528802 ]
ASF GitHub Bot commented on OODT-693: ------------------------------------- Github user chrismattmann commented on a diff in the pull request: https://github.com/apache/oodt/pull/66#discussion_r199326255 --- Diff: filemgr/src/main/java/org/apache/oodt/cas/filemgr/cli/action/FileManagerCliAction.java --- @@ -16,52 +16,47 @@ */ package org.apache.oodt.cas.filemgr.cli.action; -//JDK imports import org.apache.commons.lang.Validate; import org.apache.oodt.cas.cli.action.CmdLineAction; import org.apache.oodt.cas.filemgr.structs.exceptions.ConnectionException; import org.apache.oodt.cas.filemgr.system.FileManagerClient; import org.apache.oodt.cas.filemgr.util.RpcCommunicationFactory; -import java.io.IOException; import java.net.MalformedURLException; import java.net.URL; -//Apache imports -//OODT imports - /** * Base {@link CmdLineAction} for File Manager. * * @author bfoster (Brian Foster) */ public abstract class FileManagerCliAction extends CmdLineAction { - private FileManagerClient client; + private FileManagerClient fmc; - public String getUrl() { - return System.getProperty("org.apache.oodt.cas.filemgr.url"); - } + public String getUrl() { + return System.getProperty("org.apache.oodt.cas.filemgr.url"); + } - protected FileManagerClient getClient() throws MalformedURLException, ConnectionException { - Validate.notNull(getUrl(), "Must specify url"); + /** + * TODO(imesha) Fix client closing problem which makes it usable only once --- End diff -- should we open up a separate issue for this? > Consolidate logging in OODT > --------------------------- > > Key: OODT-693 > URL: https://issues.apache.org/jira/browse/OODT-693 > Project: OODT > Issue Type: Improvement > Components: file manager > Affects Versions: 0.6 > Reporter: Lewis John McGibbney > Priority: Major > Fix For: 1.1 > > > Right now we seem to be using an array of inconsistent logging frameworks. > Personally I really like the Slf4j over Log4j setup. Extremely easy to work > with, easy to configure and Log4j 2.X is dynamite so if we can implement that > then we are laughing. > This is by no means a trivial task. > It is however an important one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)