Hey tucu, Can the test-patch also post an overall summary? If all is +1, then Overall: +1 and otherwise?
And since our JIRA supports formatting, we could also color-code the -1 lines. Makes it easier to spot and helps avoid mistakes when scanning through. On Thu, Aug 23, 2012 at 10:18 AM, Alejandro Abdelnur <[email protected]> wrote: > Today I've added javadocs/backwards-compat/distro checks. > > While there are still some rough edges here and there, I think it is > ready for use. > > As the jenkins jobs are running (patch-finder and test-patch) you only > need to upload a patch to JIRA and mark the JIRA as Patch Available. > Uploading a new patch to a JIRA already marked as Patch Available will > do. > > The intended usage is as follows: > > * test-patch can be run locally: bin/test-patch --patch=<PATH TO > PATCH> --reset-scm. It is suggested you run it before uploading a > patch to JIRA, this would speed up the review cycle. > > * when you have patch ready upload it to the JIRA and mark the JIRA as > patch available if necessary. > * once test-patch posts the results... > ** if all +1 a fellow developer would review > ** if some -1 > *** justify the -1s, then a fellow developer would review > *** post an updated patch fixing the issues > > currently test-patch can only look at patches in JIRA, not in review board. > > I'll create a wiki page with all the details and examples. > > Thx > > -- > Alejandro -- Harsh J
