[ 
https://issues.apache.org/jira/browse/OOZIE-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492515#comment-13492515
 ] 

Harsh J commented on OOZIE-1015:
--------------------------------

Patch looks OK to me. I just have a few mostly off-topic questions:

# What is the difference between using XOozieClient.JT in the AccessorService 
vs. constant HADOOP_JOB_TRACKER (and _2?) in JavaActionExecutor?
# Also, the renewer string we pass for tokens, "mr token", perhaps we can make 
it "oozie mr token" for better traceability, if thats a compatible change to 
make?
                
> HadoopAccessorService jobtracker validation should not have hardcoded conf key
> ------------------------------------------------------------------------------
>
>                 Key: OOZIE-1015
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1015
>             Project: Oozie
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>            Reporter: Mona Chitnis
>            Assignee: Mona Chitnis
>             Fix For: trunk
>
>         Attachments: OOZIE-1015.patch
>
>
> While validating the jobtracker address against whitelist in 
> HadoopAccessorService, the conf key to be looked up is a string value 
> "mapred.job.tracker". Instead we should use static variables for robustness 
> (mapred.job.tracker for hadoop-1 and yarn.resourcemanager.address for 
> hadoop-2)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to