> On Nov. 30, 2012, 6:25 p.m., Robert Kanter wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/workflowgenerator/xsd/XmlLoaderTest.java, > > line 28 > > <https://reviews.apache.org/r/8232/diff/1/?file=231062#file231062line28> > > > > I think you should add some more tests. Specifically, a negative test > > where the input XML is "bad" in some way.
Robert, I will add more tests - jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8232/#review13902 ----------------------------------------------------------- On Dec. 3, 2012, 9:57 a.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8232/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2012, 9:57 a.m.) > > > Review request for oozie. > > > Description > ------- > > There will be xml import and export for wfgen. > They should be done through a xml binding library, which makes serialization > and deserialization simpler with oozie's xsd. > I made a patch with jaxb2 and please review it. > > > This addresses bug OOZIE-1085. > https://issues.apache.org/jira/browse/OOZIE-1085 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/pom.xml > 1416405 > > http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/xsd/XmlLoader.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/xjb/oozie-workflow-0.3.xjb > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/main/xjb/oozie-workflow-0.4.xjb > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/workflowgenerator/xsd/XmlLoaderTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/8232/diff/ > > > Testing > ------- > > unit test attached. > > > Thanks, > > jun aoki > >
