> On Dec. 5, 2012, 12:09 a.m., Mohammad Islam wrote: > > Why are you changing back to adding "database", "table" etc? I think we > > talked to add "partition". > > Although it was our original plan. We changed it after getting feedback > > from Alejandro. As stated "database & table, why not assuming the database > > and table names are the first and second elements of the path, then instead > > hcat:host:port/db/<DB>/table/<TABLE>/... it would just be > > #hcat:host:port/<DB>/<TABLE>/...". > > > > Ryota Egashira wrote: > yeah, we removed it in original design, but to follow templeton URI > format which require these, we are adding > > https://issues.apache.org/jira/browse/OOZIE-561?focusedCommentId=13509053&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13509053
That's the templeton format (http://people.apache.org/~thejas/templeton_doc_latest/descpartition.html). If we are trying to comply with it, we should totally comply with it (https://issues.apache.org/jira/browse/OOZIE-561?focusedCommentId=13509053&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13509053). Adding partition without database and table does not make sense. Else we can go with hcat:host:port/<DB>/<TABLE>/<PARTITION> assuming that the third one will be partition. Both has its pros and cons. One would be more standard complying with hcatalog folks. The other is simplified (less to type for user) and takes less space for string while storing in database. Had not thought about templeton uri taking more space in oozie database before. We need an agreement on the final format of the uri. I am fine with either one of the two approaches except the former one where partition was part of query params. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8342/#review14037 ----------------------------------------------------------- On Dec. 4, 2012, 9:14 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8342/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2012, 9:14 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1111 > > HCatURI/TestHCatURI part is done, but still work in progress of changing > other test cases using old URI format. > > > This addresses bug OOZIE-1111. > https://issues.apache.org/jira/browse/OOZIE-1111 > > > Diffs > ----- > > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java > 1416701 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionUpdatePushMissingDependency.java > 1416701 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java > 1416701 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java > 1416701 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java > 1416701 > > Diff: https://reviews.apache.org/r/8342/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
