[ 
https://issues.apache.org/jira/browse/OOZIE-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532539#comment-13532539
 ] 

Robert Kanter commented on OOZIE-1126:
--------------------------------------

That's pretty cool.  Two things:

1) Is there a way to have the messages all start with a prefix of some kind?  
Most of the stuff main prints starts with {{[INFO]}} but the checkstyle 
messages don't start with anything 
{code}/Users/rkanter/dev/oozie-trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java:9:
 warning: Line does not match expected header line of ' *'.{code}  Perhaps 
{{[STYLE]}}?  This would make it easier to see the checkstyle comments in the 
output.  

2) This probably isn't easily doable, but is there a way to have it only print 
the style warnings for lines (or at least files) that have changed?  As you 
said the current code has a lot of violations so its hard to pick out what is 
relevant to our current code changes vs what was already there.  
                
> see if checkstyle works for oozie development.
> ----------------------------------------------
>
>                 Key: OOZIE-1126
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1126
>             Project: Oozie
>          Issue Type: Task
>          Components: build
>    Affects Versions: trunk
>            Reporter: jun aoki
>            Assignee: jun aoki
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: OOZIE-1126.patch
>
>
> Currently, some code style check is done at the precmomit build
> http://svn.apache.org/viewvc/oozie/trunk/bin/
> It can be done at local machine by maven checkstyle plugin, so that devs 
> would get much faster feedback comparing to waiting a precommit build 
> completes on Jenkins server.
> The original thread is here
> http://mail-archives.apache.org/mod_mbox/oozie-dev/201212.mbox/%3CCAFc2gLnff6EABP2EWXgqfexaTy2PJETNuUtenmVrYVhF8%2Ba0vg%40mail.gmail.com%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to