-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8897/#review15586
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/8897/#comment33670>

    Abstract this details here and have a method like handleFailure() and 
override it in PigAE



trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
<https://reviews.apache.org/r/8897/#comment33671>

    move the finally to the inner try-catch.


- Virag Kothari


On Jan. 22, 2013, 9:46 p.m., Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8897/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 9:46 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1160
> 
> 
> This addresses bug OOZIE-1160.
>     https://issues.apache.org/jira/browse/OOZIE-1160
> 
> 
> Diffs
> -----
> 
>   
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
>  1436833 
>   trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 
> 1436833 
>   trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java 
> 1436833 
>   
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java
>  1436833 
>   trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 
> 1436833 
>   trunk/webapp/src/main/webapp/oozie-console.js 1436833 
> 
> Diff: https://reviews.apache.org/r/8897/diff/
> 
> 
> Testing
> -------
> 
> e-2-e tested
> 
> 
> Thanks,
> 
> Mona Chitnis
> 
>

Reply via email to