----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9061/#review15659 -----------------------------------------------------------
Ship it! +1..looks good...couple of comments below http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java <https://reviews.apache.org/r/9061/#comment33783> javadoc here and for other public stuff http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java <https://reviews.apache.org/r/9061/#comment33781> this method may be called simultaneously for the same jmsconnectString so we should only schedule retry for a connection if its not already done http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/SchedulerService.java <https://reviews.apache.org/r/9061/#comment33782> Can we reuse the existing methods of Scheduler SErvice - Virag Kothari On Jan. 24, 2013, 9:58 p.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9061/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2013, 9:58 p.m.) > > > Review request for oozie. > > > Description > ------- > > Retry jms connections on failure backing off exponentially (1min,2 min, > 4,8,16..) up to a max limit > > > This addresses bug OOZIE-1185. > https://issues.apache.org/jira/browse/OOZIE-1185 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java > 1438212 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java > 1438212 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java > 1438212 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1438212 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/SchedulerService.java > 1438212 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 1438212 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/test/MiniHCatServer.java > 1438212 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/hcatalog-0.6.0-SNAPSHOT/pom.xml > 1438212 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/hcatalog-0.6/pom.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/hcataloglibs/pom.xml > 1438212 > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1438212 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/src/main/assemblies/hcataloglib.xml > 1438212 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/src/main/assemblies/hcataloglibs.xml > 1438212 > > Diff: https://reviews.apache.org/r/9061/diff/ > > > Testing > ------- > > > Thanks, > > Rohini Palaniswamy > >
