----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9026/#review15709 -----------------------------------------------------------
Since JMS connection close utilizing patterncount is TODO, can we abstract code that is common between ehCache impl and simpleCache impl to the parent class, to avoid duplication? - Mona Chitnis On Jan. 24, 2013, 9:51 p.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9026/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2013, 9:51 p.m.) > > > Review request for oozie. > > > Description > ------- > > Cache based on ehcache which has eviction, ttl, max elements in memory and > overflow to disk configurable > > > Diffs > ----- > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml > 1437215 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/cache/EhcacheHCatDependencyCache.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/cache/WaitingActions.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/resources/ehcache-default.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > 1437215 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/resources/ehcache.xml > PRE-CREATION > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1437215 > > Diff: https://reviews.apache.org/r/9026/diff/ > > > Testing > ------- > > > Thanks, > > Rohini Palaniswamy > >
