----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9104/#review15722 -----------------------------------------------------------
Ship it! looks fine. Disclaimer here as we discussed before, that later we may decide to revamp the SLA architecture completely. trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java <https://reviews.apache.org/r/9104/#comment33873> better to remove these commented lines altogether - Mona Chitnis On Jan. 25, 2013, 8:19 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9104/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2013, 8:19 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1187 > > > This addresses bug OOZIE-1187. > https://issues.apache.org/jira/browse/OOZIE-1187 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1437603 > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1437603 > trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java > 1437603 > > trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java > 1437603 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java > 1437603 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java > 1437603 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java > 1437603 > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1437603 > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1437603 > > Diff: https://reviews.apache.org/r/9104/diff/ > > > Testing > ------- > > locally tested. ran coordinator jobs with SLA tag inserted > > > Thanks, > > Ryota Egashira > >
