----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9739/#review18013 -----------------------------------------------------------
This patch looks good Couple of comments not regarding to the patch but can be included in this patch 1) Group is shown as blank in registration event, would be good to populate it 2) User and group are seen as blank in status event, would be good to set them - Virag Kothari On March 4, 2013, 11:19 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9739/ > ----------------------------------------------------------- > > (Updated March 4, 2013, 11:19 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1246 > > > This addresses bug OOZIE_1246. > https://issues.apache.org/jira/browse/OOZIE_1246 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1452464 > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java > 1452464 > > Diff: https://reviews.apache.org/r/9739/diff/ > > > Testing > ------- > > tested locally > > > Thanks, > > Ryota Egashira > >
