[ 
https://issues.apache.org/jira/browse/OOZIE-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606986#comment-13606986
 ] 

Hadoop QA commented on OOZIE-1118:
----------------------------------

Testing JIRA OOZIE-1118

Cleaning local svn workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:red}-1{color} the patch contains 6 line(s) longer than 132 
characters
.    {color:green}+1{color} the patch does adds/modifies 11 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1069
.    Tests failed: 1
.    Tests errors: 0

.    The patch failed the following testcases:

.      
testStartNonTransientWithCoordActionUpdate(org.apache.oozie.command.wf.TestActionErrors)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/393/
                
> improve logic of purge service
> ------------------------------
>
>                 Key: OOZIE-1118
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1118
>             Project: Oozie
>          Issue Type: Improvement
>          Components: bundle, coordinator, workflow
>    Affects Versions: 3.3.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Robert Kanter
>             Fix For: trunk
>
>         Attachments: OOZIE-1118.patch, OOZIE-1118.patch, OOZIE-1118.patch, 
> OOZIE-1118.patch, OOZIE-1118.patch
>
>
> The current logic of the purge service is flat. I.e., WF purging only takes 
> into account WF end time, it does not take into account that the WF was 
> started by a COORD job. This means that completed WFs of a running COORD job 
> could be purge if the COORD job runs for longer that the purge age.
> One way of addressing this would be:
> * WF purging only purges WF jobs started directly by a client call.
> * COORD purging purges COORD jobs started directly by a client call. It also 
> purges the WF jobs created by the COORD jobs being purged.
> * BUNDLE purging purges BUNDLE jobs, and the corresponding COORD jobs and WF 
> jobs.
> This could be handled by a new property in the job beans 'job-owner'. Set to 
> 'self' it would mean it can be purged by the same job type purger. If set to 
> other value, then it is a higher level purger the one responsible for purging 
> it.
> This means that for a WF job started by COORD job started by a BUNDLE job, 
> the WF job and the COORD job would have the BUNDLE job as owner, while the 
> BUNDLE with have 'self' as owner.
> This ownership propagation would also have
> A caveat here would be how to handle sub-workflows. 
> I guess we should check if the wf was created from  coord, and if then let 
> the coord purge take care of that, meaning wf purge does not purge wf started 
> by coords.
> Similarly, the same should also apply for sub-WFs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to