----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/ -----------------------------------------------------------
(Updated March 21, 2013, 7:40 p.m.) Review request for oozie. Changes ------- Based on comments in meetup, added a generic topic service which can allow topic to be variables like ${username}, ${jobId} or ${username}.${jobId}. Also it can be a fixed string like 'workflow, 'coord' etc. Topics can also be specified at job level. For. e.g Topic name for workflow can be '${jobId}' and for coordinator it can be a fixed string 'coord' Description ------- https://issues.apache.org/jira/browse/OOZIE-1235 This addresses bug OOZIE-1235. https://issues.apache.org/jira/browse/OOZIE-1235 Diffs (updated) ----- trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java PRE-CREATION trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407 trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1459407 trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1459407 trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1459407 trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1459407 trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407 trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407 trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407 trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407 trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407 trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407 trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 1459407 trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1459407 trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407 trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407 trunk/core/src/main/resources/oozie-default.xml 1459407 trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1459407 trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1459407 Diff: https://reviews.apache.org/r/9709/diff/ Testing ------- Thanks, Virag Kothari