> On April 4, 2013, 12:07 a.m., Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java, line > > 300 > > <https://reviews.apache.org/r/9942/diff/9/?file=274750#file274750line300> > > > > same as purgeWF
Because coordinators can't have other Coords as children (i.e. no dependencies between them), we can actually delete them in any order; I only did it like this because I had to for WFs. So, I think you're right that it would be simpler to do this in a forward loop by chunks (though we don't need to do Collections.reverse() on it). > On April 4, 2013, 12:07 a.m., Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java, line > > 313 > > <https://reviews.apache.org/r/9942/diff/9/?file=274750#file274750line313> > > > > same as purgeWF > > > > Same as purgeCoordinators - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9942/#review18677 ----------------------------------------------------------- On March 27, 2013, 12:18 a.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9942/ > ----------------------------------------------------------- > > (Updated March 27, 2013, 12:18 a.m.) > > > Review request for oozie. > > > Description > ------- > > Patch for OOZIE-1118 (improve logic of purge service) > > See https://issues.apache.org/jira/browse/OOZIE-1118 for more info > > > This addresses bug OOZIE-1118. > https://issues.apache.org/jira/browse/OOZIE-1118 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1460860 > trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1460860 > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1460860 > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1460860 > trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1460860 > trunk/core/src/main/java/org/apache/oozie/command/PurgeXCommand.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePurgeXCommand.java > 1460860 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPurgeXCommand.java > 1460860 > trunk/core/src/main/java/org/apache/oozie/command/wf/PurgeXCommand.java > 1460860 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkDeleteForPurgeJPAExecutor.java > 1460860 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetForPurgeJPAExecutor.java > 1460860 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsCountNotForPurgeFromParentIdJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetForPurgeJPAExecutor.java > 1460860 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetFromParentIdJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetForPurgeJPAExecutor.java > 1460860 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsGetFromParentIdJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java 1460860 > trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java > 1460860 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java > 1460860 > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java > 1460860 > trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java > 1460860 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkDeleteForPurgeJPAExecutor.java > 1460860 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java > 1460860 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java > 1460860 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromParentIdJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java > 1460860 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromParentIdJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java > 1460860 > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1460860 > > Diff: https://reviews.apache.org/r/9942/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
