----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9602/#review18693 -----------------------------------------------------------
In some places for generating coordinator action event, the queries need to be updated. For. e.g we are doing coordAction.getCreatedTime() while constructing the event, but the the coordaction might not have that attribute and jpa query need to be updated to account for that. To ensure that we dont miss cases like this, it would be good to have testcases which check for each and every attributes which are used in constructing the event. trunk/client/src/main/java/org/apache/oozie/client/event/Event.java <https://reviews.apache.org/r/9602/#comment39101> remove this and above javadoc trunk/core/src/main/java/org/apache/oozie/command/XCommand.java <https://reviews.apache.org/r/9602/#comment39102> remove trunk/core/src/main/java/org/apache/oozie/command/XCommand.java <https://reviews.apache.org/r/9602/#comment39103> remove trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java <https://reviews.apache.org/r/9602/#comment39104> coord job shouldn't be null, remove this condition trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java <https://reviews.apache.org/r/9602/#comment39105> seems the change is not required. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java <https://reviews.apache.org/r/9602/#comment39106> user and appname need to be set in constructor otherwise it will be null Can we please have a test case for this? trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java <https://reviews.apache.org/r/9602/#comment39107> coord job shouldnt be null trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java <https://reviews.apache.org/r/9602/#comment39108> if pushMissDep is null this would wind up as HCAT:null I dont think we need HDFS or HCAT as prependers. We should emulate OozieCLI to preserve consistency basically missdep+Instace_seperator+pushMissdep trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java <https://reviews.apache.org/r/9602/#comment39109> can we obtain a reference to EHS during class loading and use to avoid this get() everytime? trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java <https://reviews.apache.org/r/9602/#comment39110> same as above trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java <https://reviews.apache.org/r/9602/#comment39111> same comment as before for having single ref trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java <https://reviews.apache.org/r/9602/#comment39112> same comment trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java <https://reviews.apache.org/r/9602/#comment39114> should we have debug instead of info? asking as we can have lot of events/sec Same comment for all events trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java <https://reviews.apache.org/r/9602/#comment39113> I thought we had an agreement on passing the actual job's end time instead of new Date() to have a consistency between job and event's end time. trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/9602/#comment39116> wrong logic if (listenerlist==null){ listenersList = new ArrayList(); map.put(..,..); } listenersList.add(listener) same comment for slaeventlistener trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/9602/#comment39123> what is the concept behind schedThreads and workerThreads? These variables are unused. trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/9602/#comment39125> setAppTypes trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/9602/#comment39126> getAppTypes trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/9602/#comment39127> it seems it would be better to check for empty queue without polling in batch first - Virag Kothari On April 5, 2013, 12:20 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9602/ > ----------------------------------------------------------- > > (Updated April 5, 2013, 12:20 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1209 > WIP patch > > > This addresses bug OOZIE-1209. > https://issues.apache.org/jira/browse/OOZIE-1209 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1464795 > trunk/client/src/main/java/org/apache/oozie/client/event/Event.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464795 > > trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1464795 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java > 1464795 > > trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java > PRE-CREATION > trunk/core/src/main/resources/oozie-default.xml 1464795 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java > 1464795 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9602/diff/ > > > Testing > ------- > > unit tests added > > > Thanks, > > Mona Chitnis > >
