[
https://issues.apache.org/jira/browse/OOZIE-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634188#comment-13634188
]
Alejandro Abdelnur commented on OOZIE-1232:
-------------------------------------------
Comments on the patch:
* If we are factoring out the hadoopconfs logic from HadoopAccessorService into
a separate service, we should remove such logic from HadoopAccessorService
itself.
* Instead having GroupsService extends HadoopConfsService, I'd rather have
HadoopConfsService as a regular service and GroupsService &
HadoopAccessorService using it.
Comments on the approach:
The current hadoopconfs mechanism is designed to pick a configuration based on
the JT/RM/NN specified in applications. The main purpose is to allow a single
Oozie server to interact correctly with multiple hadoop clusters using the
correct site configuration of each of them.
In the way the patch uses hadoopconfs, it is overloading the original intent
and using a hadoop cluster specific configuration for the oozie server itself.
If we would do such thing, I'd would argue we should have a special hadoopconf/
for Oozie, and not overload the use of the hadoopconfs meant for jobs.
Second, the fact that Oozie leverages Hadoop's groups mechanism by default is
an implementation detail of the GroupsService. I don't think is correct to
bubble up hadoop configuration to oozie because of a service implementation.
And the fact that there is a way to specify configuration props to the Hadoop
groups impl used by Oozie (by prefixing them with
'oozie.service.GroupsService.') strengthens my view of this.
Third, Oozie does not assume/expect today that there is a hadoop-conf available
in the oozie server. With this change it would.
> GroupsService should be able to reference Hadoop configurations in Hadoop
> configuration folder (such as /etc/hadoop/conf)
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-1232
> URL: https://issues.apache.org/jira/browse/OOZIE-1232
> Project: Oozie
> Issue Type: Improvement
> Components: security
> Affects Versions: trunk
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Labels: GroupsService, hadoop-conf
> Fix For: trunk
>
> Attachments: OOZIE-1232.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Oozie GroupsService wraps Hadoop user groups mapping to get groups for user,
> which requires to reference Hadoop configurations, especially the properties
> related to groups mapping provider (such as LdapGroupsMapping).
> To avoid replication of such configurations into oozie-site.xml, mechanism is
> needed to configure the Hadoop configurations folder (often mentioned
> hadoop-conf) for the service, as HadoopAccessorService currently does.
> Such work can be done per Service, as HadoopAccessorService, but would it be
> better to avoid code changes or similar work when other Service also needs to
> do that in future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
