> On April 18, 2013, 5:01 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/service/URIHandlerService.java, > > line 201 > > <https://reviews.apache.org/r/10593/diff/2/?file=282176#file282176line201> > > > > It will bloat up the logs. Can we remove it?
As relative paths are uncommon, I dont believe it will bloat the logs. But can change it to log.trace > On April 18, 2013, 5:01 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/test/java/org/apache/oozie/dependency/TestURIHandlerService.java, > > lines 31-45 > > <https://reviews.apache.org/r/10593/diff/2/?file=282178#file282178line31> > > > > Why is all this required? Required for testing the getURIHandler() of URIHandlerService. As the init() of URI handler services initializes the handlers, this was required. > On April 18, 2013, 5:01 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/test/java/org/apache/oozie/dependency/TestURIHandlerService.java, > > line 71 > > <https://reviews.apache.org/r/10593/diff/2/?file=282178#file282178line71> > > > > Services.get() can be used instead of using a local variable. Just one > > more assert can be added as part of previous test for /tmp/file instead of > > another test. Each test sets up service and destroy and adds time to the > > test run. We already have the 'services' instance variable. So reusing that. That assert for /tmp/file is already added in previous test but it will only check the returned URI by getAuthorityWithScheme This method tests that the getURIHandler() returns the default handler when scheme is null (for relative path) As two different public methods, adding two separate test cases - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10593/#review19394 ----------------------------------------------------------- On April 18, 2013, 1:20 a.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10593/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 1:20 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1331 > > > This addresses bug OOZIE-1331. > https://issues.apache.org/jira/browse/OOZIE-1331 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/service/URIHandlerService.java > 1469084 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1469084 > > trunk/core/src/test/java/org/apache/oozie/dependency/TestURIHandlerService.java > 1469084 > trunk/core/src/test/resources/coord-job-for-matd-relative.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/10593/diff/ > > > Testing > ------- > > Test cases added > > > Thanks, > > Virag Kothari > >
