----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10801/#review19779 -----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java <https://reviews.apache.org/r/10801/#comment40812> Pass message object to deserializer instead of TextMessage trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java <https://reviews.apache.org/r/10801/#comment40797> Load oozie_client.properties in static block and also keep all this code in getDeserializer(String msgFormat) instead of deserializerString trunk/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java <https://reviews.apache.org/r/10801/#comment40815> Can we remove the ThreadLocal initialValue() and get() and do a createSession here if get() is null. It will automatically throw JMSException also trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java <https://reviews.apache.org/r/10801/#comment40816> Can we have retry removed from signature here and always have it as false. Same for createConnectionContext (retry always true). Will have unexpected behaviour if retry is set differently. trunk/core/src/test/java/org/apache/oozie/jms/TestDefaultConnectionContext.java <https://reviews.apache.org/r/10801/#comment40819> Can we remove the commented code? - Rohini Palaniswamy On April 26, 2013, 4:19 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10801/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 4:19 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1347 > > > This addresses bug OOZIE-1347. > https://issues.apache.org/jira/browse/OOZIE-1347 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1476260 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java > 1476260 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java > 1476260 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java > 1476260 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java > 1476260 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/JobMessage.java > 1476260 > trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java > 1476260 > > trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java > 1476260 > trunk/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java > 1476260 > trunk/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java > 1476260 > trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java > 1476260 > trunk/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java > 1476260 > trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java > 1476260 > trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java 1476260 > trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1476260 > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java > 1476260 > trunk/core/src/main/resources/oozie-default.xml 1476260 > > trunk/core/src/test/java/org/apache/oozie/jms/TestDefaultConnectionContext.java > 1476260 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java > 1476260 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java > 1476260 > > Diff: https://reviews.apache.org/r/10801/diff/ > > > Testing > ------- > > > Thanks, > > Virag Kothari > >
