----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10801/#review20283 -----------------------------------------------------------
Ship it! Just 2 minor comments trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/10801/#comment41786> No _1 trunk/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java <https://reviews.apache.org/r/10801/#comment41789> Let the default be there - Rohini Palaniswamy On May 7, 2013, 11:04 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10801/ > ----------------------------------------------------------- > > (Updated May 7, 2013, 11:04 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1347 > > > This addresses bug OOZIE-1347. > https://issues.apache.org/jira/browse/OOZIE-1347 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1480077 > trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java > 1480077 > > trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfoWrapper.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1480077 > trunk/client/src/main/java/org/apache/oozie/client/event/Event.java 1480077 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java > 1480077 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java > 1480077 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java > 1480077 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java > 1480077 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/JobMessage.java > 1480077 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > 1480077 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java > 1480077 > trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1480077 > trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1480077 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1480077 > > trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java > 1480077 > > trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java 1480077 > trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1480077 > trunk/core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java > 1480077 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1480077 > trunk/core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 1480077 > trunk/core/src/main/resources/oozie-default.xml 1480077 > trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1480077 > trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java > 1480077 > trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java > 1480077 > > trunk/core/src/test/java/org/apache/oozie/jms/TestDefaultConnectionContext.java > 1480077 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java > 1480077 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java > 1480077 > > trunk/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 1480077 > trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java > 1480077 > trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java > 1480077 > trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java > 1480077 > trunk/docs/src/site/twiki/WebServicesAPI.twiki 1480077 > trunk/webapp/src/main/webapp/WEB-INF/web.xml 1480077 > > Diff: https://reviews.apache.org/r/10801/diff/ > > > Testing > ------- > > > Thanks, > > Virag Kothari > >
