-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10569/
-----------------------------------------------------------
(Updated May 9, 2013, 5:45 p.m.)
Review request for oozie.
Changes
-------
Incorporated Rohini's Review comments.
TestSLAEventGeneration is WIP for Wf Action events and Coord Action events.
Also *concern*
The SLA Schema namespace is currently hardcoded (0.1) into the
workflow/coordinator XSDs. I haven't figured out a way to allow multiple there.
Suggestions welcome.
Description
-------
1. Revisiting the SLA handling in Oozie
2. Addition of a calculator service to process sla events in a continuous
fashion
3. Added new oozie-sla schema v0.2, concise and relevant
This addresses bug OOZIE-1244.
https://issues.apache.org/jira/browse/OOZIE-1244
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/AppType.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java
1480726
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1480726
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java 1480726
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java
1480726
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java
1480726
trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java
1480726
trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java
1480726
trunk/client/src/main/java/org/apache/oozie/client/event/message/CoordinatorActionMessage.java
1480726
trunk/client/src/main/java/org/apache/oozie/client/event/message/EventMessage.java
1480726
trunk/client/src/main/java/org/apache/oozie/client/event/message/JobMessage.java
1480726
trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowJobMessage.java
1480726
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java
1480726
trunk/client/src/main/resources/oozie-sla-0.2.xsd PRE-CREATION
trunk/client/src/main/resources/oozie-workflow-0.4.5.xsd 1480726
trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java
1480726
trunk/core/pom.xml 1480726
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1480726
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1480726
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java
1480726
trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java
1480726
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1480726
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java
1480726
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java
1480726
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java 1480726
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java 1480726
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java
1480726
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java 1480726
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java
1480726
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventInsertJPAExecutor.java
1480726
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java
1480726
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java
1480726
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetJPAExecutor.java
1480726
trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculationInsertUpdateJPAExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculatorGetJPAExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java
1480726
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
1480726
trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java
1480726
trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1480726
trunk/core/src/main/java/org/apache/oozie/service/SchedulerService.java
1480726
trunk/core/src/main/java/org/apache/oozie/service/SchemaService.java 1480726
trunk/core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java
1480726
trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1480726
trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorBean.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEventListener.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAJobEventListener.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1480726
trunk/core/src/main/java/org/apache/oozie/util/SLAOperations.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/util/SLAXOperations.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java
1480726
trunk/core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java
1480726
trunk/core/src/main/resources/META-INF/oozie-postgresql-orm.xml 1480726
trunk/core/src/main/resources/META-INF/persistence.xml 1480726
trunk/core/src/main/resources/oozie-default.xml 1480726
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
1480726
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java
1480726
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
1480726
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java
1480726
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java 1480726
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLACalculationJPAExecutor.java
PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java
1480726
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java
1480726
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationGetJPAExecutor.java
PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java
1480726
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java
1480726
trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java
1480726
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java
PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java
PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java
PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1480726
trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1480726
trunk/core/src/test/resources/coord-action-sla.xml PRE-CREATION
trunk/core/src/test/resources/wf-action-sla.xml PRE-CREATION
trunk/core/src/test/resources/wf-job-sla.xml PRE-CREATION
Diff: https://reviews.apache.org/r/10569/diff/
Testing
-------
ongoing
Thanks,
Mona Chitnis
