[ 
https://issues.apache.org/jira/browse/OOZIE-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665743#comment-13665743
 ] 

jun aoki commented on OOZIE-1369:
---------------------------------

The listed RDB objects have been deleted in my patch and TestOozieDBCLI still 
passes.
{code}
        args.add("org.apache.oozie.client.rest.JsonWorkflowJob");
        args.add("org.apache.oozie.WorkflowJobBean");
        args.add("org.apache.oozie.client.rest.JsonWorkflowAction");
....
        args.add("org.apache.oozie.util.db.ValidateConnectionBean");
 
{code}

I also looked into MappingTool class (which the args variable eventually being 
passed to) source code.

http://grepcode.com/file/repo1.maven.org/maven2/org.apache.openjpa/openjpa-jdbc/2.1.0/org/apache/openjpa/jdbc/meta/MappingTool.java#1020

When the list existed, it goes to Line 1032 and parse classes from the args 
variable.
After deleting the list, it goes Line 1024 and classes are property loaded from 
persistence.xml.


                
> OozieDBCLI code should not hardcode the Oozie table filenames
> -------------------------------------------------------------
>
>                 Key: OOZIE-1369
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1369
>             Project: Oozie
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Mona Chitnis
>            Assignee: jun aoki
>             Fix For: trunk
>
>         Attachments: OOZIE-1369.patch
>
>
> The code in OozieDBCLI reads from the persistence.xml file to know the code 
> files declaring all the tables and schemas. The method 
> createMappingToolArguments() then should not duplicate and hardcode those 
> filenames again. persistence.xml should be the singular place to specify 
> openjpa tables and schema to avoid having to track 2 places

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to