-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11680/
-----------------------------------------------------------

(Updated June 10, 2013, 6:19 p.m.)


Review request for oozie.


Changes
-------

Using svn 1.7, I was able to generate a (hopefully) complete patch.  When 
committing, I'll make sure that everything is included and 'svn cp' to keep 
history etc.


Description
-------

The patch is mostly moving some files from core to the Oozie sharelib. There 
was some minor refactoring to fix some issues with tests. Otherwise, the only 
actual code changes was to add the option to use the launcher jar or not 
(oozie.action.use.launcher.jar).


This addresses bug OOZIE-1315.
    https://issues.apache.org/jira/browse/OOZIE-1315


Diffs (updated)
-----

  trunk/core/pom.xml 1491534 
  trunk/core/src/main/java/org/apache/oozie/action/hadoop/ActionStats.java 
1491534 
  trunk/core/src/main/java/org/apache/oozie/action/hadoop/ActionType.java 
1491534 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FSLauncherURIHandler.java
 1491534 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/HCatLauncherURIHandler.java
 1491534 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java 
1491534 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
1491534 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherException.java 
1491534 
  trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java 
1491534 
  trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 
1491534 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java
 PRE-CREATION 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandler.java 
1491534 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java
 1491534 
  trunk/core/src/main/java/org/apache/oozie/action/hadoop/MRStats.java 1491534 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
 1491534 
  trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java 
1491534 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 
1491534 
  trunk/core/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java 
1491534 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsDriver.java
 1491534 
  trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java 
1491534 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java
 1491534 
  trunk/core/src/main/java/org/apache/oozie/util/HCatURI.java 1491534 
  trunk/core/src/main/resources/oozie-default.xml 1491534 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java
 1491534 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHCatPrepareActions.java
 1491534 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
 1491534 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 
1491534 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java
 1491534 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
 1491534 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorUberJar.java
 1491534 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java
 1491534 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java
 1491534 
  
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java
 1491534 
  
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java
 1491534 
  trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 
1491534 
  trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1491534 
  trunk/core/src/test/java/org/apache/oozie/util/TestHCatURI.java 1491534 
  trunk/docs/src/site/twiki/AG_Install.twiki 1491534 
  trunk/examples/pom.xml 1491534 
  trunk/pom.xml 1491534 
  trunk/sharelib/distcp/pom.xml 1491534 
  trunk/sharelib/hcatalog/pom.xml 1491534 
  
trunk/sharelib/hcatalog/src/main/java/org/apache/oozie/action/hadoop/HCatLauncherURIHandler.java
 PRE-CREATION 
  trunk/sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java 
PRE-CREATION 
  trunk/sharelib/hcatalog/src/test/java/org/apache/oozie/util/TestHCatURI.java 
PRE-CREATION 
  trunk/sharelib/hive/pom.xml 1491534 
  
trunk/sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
 1491534 
  trunk/sharelib/oozie/pom.xml 1491534 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ActionStats.java
 PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ActionType.java
 PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/FSLauncherURIHandler.java
 PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherException.java
 PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java
 PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
 PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandler.java
 PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java
 PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MRStats.java 
PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java
 PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PipesMain.java
 PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsDriver.java
 PRE-CREATION 
  
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
 PRE-CREATION 
  trunk/sharelib/pig/pom.xml 1491534 
  
trunk/sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java
 1491534 
  trunk/sharelib/sqoop/pom.xml 1491534 
  
trunk/sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java
 1491534 
  trunk/sharelib/streaming/pom.xml 1491534 
  
trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
 PRE-CREATION 
  
trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorStreaming.java
 1491534 
  
trunk/sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutorUberJar.java
 PRE-CREATION 
  trunk/webapp/pom.xml 1491534 

Diff: https://reviews.apache.org/r/11680/diff/


Testing
-------

- Unit tests for oozie.action.use.launcher.jar
- I verified that it works correctly with oozie.action.use.launcher.jar set to 
true and false.


Thanks,

Robert Kanter

Reply via email to