> On June 7, 2013, 11:35 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java, > > line 372 > > <https://reviews.apache.org/r/11533/diff/1-2/?file=298439#file298439line372> > > > > There is no point in having this as a test. Unless the test goes > > through actual ActionCheckXCommand it is not actually testing anything.
to be fixed as part of OOZIE-1405 > On June 7, 2013, 11:35 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java, > > line 517 > > <https://reviews.apache.org/r/11533/diff/1-2/?file=298439#file298439line517> > > > > Remove this to be fixed as part of OOZIE-1405 - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11533/#review21603 ----------------------------------------------------------- On June 6, 2013, 5:43 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11533/ > ----------------------------------------------------------- > > (Updated June 6, 2013, 5:43 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1394 > > > This addresses bug OOZIE-1394. > https://issues.apache.org/jira/browse/OOZIE-1394 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1490363 > trunk/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java > 1490363 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1490363 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1490363 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java > 1490363 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1490363 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1490363 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsRunningJPAExecutor.java > 1490363 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSuspendedJPAExecutor.java > 1490363 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1490363 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1490363 > > Diff: https://reviews.apache.org/r/11533/diff/ > > > Testing > ------- > > added test for coord rerun/resume case. > > > Thanks, > > Mona Chitnis > >
