----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11797/#review22545 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11797/#comment46256> need to retrieve from both slasummary and registration trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11797/#comment46257> if SLASummaryUpdateForSLAStatusJPAExecutor is no longer used, delete the file trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11797/#comment46258> need to set ended=true here trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11797/#comment46259> processDuration will overwrite the END event with DUration event. Move this if block above isMiss block, that will fix it it seems. Can we have a testcase? trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java <https://reviews.apache.org/r/11797/#comment46261> make sure this is not flaky trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java <https://reviews.apache.org/r/11797/#comment46255> check the eventProcessed byte is set correctly, also check if job is removed from memory. - Virag Kothari On June 28, 2013, 10:22 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11797/ > ----------------------------------------------------------- > > (Updated June 28, 2013, 10:22 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1379 > https://issues.apache.org/jira/browse/OOZIE-1379 > > > Repository: oozie > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1379 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1497884 > trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1497884 > trunk/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java > 1497884 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1497884 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1497884 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1497884 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > 1497884 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > 1497884 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > 1497884 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > 1497884 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusActualTimesJPAExecutor.java > 1497884 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusJPAExecutor.java > 1497884 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1497884 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1497884 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1497884 > trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1497884 > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > 1497884 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1497884 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1497884 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java > 1497884 > trunk/core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java > 1497884 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1497884 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 1497884 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java > 1497884 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1497884 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 1497884 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > 1497884 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java > 1497884 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1497884 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java > 1497884 > trunk/core/src/test/resources/coord-action-sla1.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/11797/diff/ > > > Testing > ------- > > added unit test > > > Thanks, > > Mona Chitnis > >
