> On Aug. 9, 2013, 5:45 p.m., Bowen Zhang wrote: > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java, > > lines 721-722 > > <https://reviews.apache.org/r/13362/diff/3/?file=338697#file338697line721> > > > > No, in the past with constant frequency, we don't need this statement > > since a coordinator job is guaranteed to finish running after the last > > action is done. With cron frequency, you can have a coordinator job that > > finishes last action while still have more materializations to go even > > though it won't create any actions. When this coord job reaches end time, > > its last action is long over. > > Take this job as an example: freq="0,30 1-2 * * *", > > startTime=2013-08-11T01:00Z, endtime=2013-08-11T04:00Z. Right after 2:30, > > the status transit service won't update the terminal status of this job > > since it's not done with materialization although its last action is > > finished according to the frequency.
We should be setting the done materialization to true at 2:30, as there are no more actions to materialize, instead of adding this check to StatusTransitService. The current approach also would mark the coord job SUCCEEDED 1.5 hrs after it actually succeeded which is not what a user would expect. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13362/#review24928 ----------------------------------------------------------- On Aug. 8, 2013, 6:33 p.m., Bowen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13362/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 6:33 p.m.) > > > Review request for oozie, Robert Kanter and Rohini Palaniswamy. > > > Repository: oozie > > > Description > ------- > > oozie-1306 cron scheduling for coordinator job > > > Diffs > ----- > > /trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1511139 > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1511139 > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1511139 > > /trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetRunningPastEndtimeJPAExecutor.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1511139 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 1511139 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1511139 > > /trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetRunningPastEndtimeJPAExecutor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/13362/diff/ > > > Testing > ------- > > > Thanks, > > Bowen Zhang > >
