> On Oct. 1, 2013, 3:21 p.m., Rohini Palaniswamy wrote: > > Previously you had added CoordJobsGetRunningPastEndtimeJPAExecutor to > > handle cron frequencies which will still have more materializations to go > > even though it won't create any actions. Had asked to set done > > materialization to true if next materialization time is after coord job end > > time. CoordJobsGetRunningPastEndtimeJPAExecutor is removed, but setting > > done materialization is not in this patch.
It's not needed anymore actually as long as we set the next materialization time correct, we don't need to setDone here. > On Oct. 1, 2013, 3:21 p.m., Rohini Palaniswamy wrote: > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java, > > line 294 > > <https://reviews.apache.org/r/13362/diff/6/?file=356942#file356942line294> > > > > Wasn't DST transition in 11 March 2012 2am ? > > > > Also on the boundary of transition, we expect it to be forward by one > > hour in Spring DST and backward by one hour in Winter DST. > > > > Refer to TestCoordELFunctions.testCurrent. That's exactly what the UTC time is testing. > On Oct. 1, 2013, 3:21 p.m., Rohini Palaniswamy wrote: > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java, > > line 319 > > <https://reviews.apache.org/r/13362/diff/6/?file=356942#file356942line319> > > > > 4th November 2am was DST. Refer to previous comment. - Bowen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13362/#review26557 ----------------------------------------------------------- On Sept. 25, 2013, 2:01 a.m., Bowen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13362/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2013, 2:01 a.m.) > > > Review request for oozie, Robert Kanter and Rohini Palaniswamy. > > > Repository: oozie > > > Description > ------- > > oozie-1306 cron scheduling for coordinator job > > > Diffs > ----- > > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1526083 > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1526083 > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1526083 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 1526083 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1526083 > /trunk/examples/src/main/apps/cron-schedule/coordinator.xml PRE-CREATION > /trunk/examples/src/main/apps/cron-schedule/job.properties PRE-CREATION > /trunk/examples/src/main/apps/cron-schedule/workflow.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/13362/diff/ > > > Testing > ------- > > > Thanks, > > Bowen Zhang > >
