----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15211/#review29200 -----------------------------------------------------------
The tests are not actually asserting for the json response as it is empty because the SharelibService is null for test case. Need to fix that and ensure test case exercises the full code path. I am fine with doing it in another jira. http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java <https://reviews.apache.org/r/15211/#comment56345> formatting http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java <https://reviews.apache.org/r/15211/#comment56346> e.getClass().getName() + ": " + e.getMessage() http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/15211/#comment56350> Can we put sharelibMetaFileOldTimeStamp, sharelibMetaFileNewTimeStamp, sharelibDirOld, sharelibDirNew to see what was before and after the update? http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/15211/#comment56343> modifiedDate(dd-MM-yyyy HH:mm:ss) has no problem with json? Anyways remove the (dd-MM-yyyy HH:mm:ss) and use the standard oozie format for printing dates (DateUtils.formatDateOozieTZ). Date format should always be MM-dd-yyyy and not dd-MM-yyyy. http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/15211/#comment56344> formatting http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/15211/#comment56347> used to http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/15211/#comment56348> We can remove the indent for sharelib name and keep the indent only for files http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/15211/#comment56349> timestamp or reloads the sharelib metafile if one is configured. The main purpose is to update the sharelib on the oozie server ... - Rohini Palaniswamy On Nov. 20, 2013, 11:35 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15211/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2013, 11:35 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1519 > https://issues.apache.org/jira/browse/OOZIE-1519 > > > Repository: oozie > > > Description > ------- > > Admin command to update the sharelib. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestShareLibService.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_CommandLineTool.twiki > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WebServicesAPI.twiki > 1542384 > > Diff: https://reviews.apache.org/r/15211/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
