[
https://issues.apache.org/jira/browse/OOZIE-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834217#comment-13834217
]
Robert Kanter commented on OOZIE-1575:
--------------------------------------
Comments; mostly minor things:
# Shouldn't we allow the {{-P}} argument to let users specify
parameters/variables? In {{OozieCLI}}, we don't list it as an option, and
there's an unused {{paramsList}} variable.
# In {{XOozieClient#serializeSqoopCommand}}, {{sb.append(arg + "\n");}} can be
replaced by {{sb.append(arg).append("\n");}}
# {{XOozieClient#submitSqoop}} doesn't appear to actually throw an
{{IOException}}
# In {{XOozieClient#submitSqoop}} there's no reason to store the constants
{{SQOOP_COMMAND}} and {{SQOOP_OPTIONS}} as local variables, just use them
directly
# The javadoc for {{DagEngine#submitHttpJob}} should be updated to reflect that
it now accepts "sqoop" as well
# {{SubmitSqoopXCommand#generateSection}} doesn't use the {{otherArgs}}
variable for anything; it can be deleted
# The {{generateConfigurationSection}} method in {{SubmitSqoopXCommand}} and
{{SubmitScriptLanguageXCommand}} are identical; we should move this up to
{{SubmitHttpXCommand}} so that (a) there's only one copy of this method and (b)
future "{{SubmitWhateverXCommand}}" classes can use it
# Similarly, the {{getWorkflowXml}} can also be pulled up to
{{SubmitHttpXCommand}}; you just need to add an abstract method to return the
"name" that {{SubmitSqoopXCommand}}, {{SubmitPigXCommand}}, etc can implement.
# Also take care of the line that's too long and check if the javac warning is
a false positive; the test failures were being caused by something else and
should be fixed now
> Add functionality to submit sqoop jobs through http on oozie server side
> ------------------------------------------------------------------------
>
> Key: OOZIE-1575
> URL: https://issues.apache.org/jira/browse/OOZIE-1575
> Project: Oozie
> Issue Type: Sub-task
> Components: client
> Reporter: Bowen Zhang
> Assignee: Bowen Zhang
> Fix For: trunk
>
> Attachments: oozie-1575.patch, oozie-1575.patch, oozie-1575.patch,
> oozie-1575.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
