> On Dec. 16, 2013, 9:01 p.m., Rohini Palaniswamy wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java, > > line 56 > > <https://reviews.apache.org/r/16300/diff/2/?file=398323#file398323line56> > > > > V==1 should be sufficient. Or use some special chars from ascii charset > > like #!1. Not more than 3 byte overhead.
v==1 > On Dec. 16, 2013, 9:01 p.m., Rohini Palaniswamy wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java, > > line 624 > > <https://reviews.apache.org/r/16300/diff/2/?file=398323#file398323line624> > > > > There will be NPE if the value is null. If (value == null) just do > > dOut.writeUTF(null) without version as you are already checking for null in > > read function It will be never null, bcz of.. public void setVar(String name, String value) { if (value != null) { persistentVars.put(name, value); } else { persistentVars.remove(name); } } But it's always good to put extra check. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16300/#review30483 ----------------------------------------------------------- On Dec. 16, 2013, 9:24 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16300/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 9:24 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1642 > https://issues.apache.org/jira/browse/OOZIE-1642 > > > Repository: oozie > > > Description > ------- > > java.io.DataOutputStream.writeUTF has a limit of 64k, if counter size > 64k > it throws > java.lang.RuntimeException: java.io.UTFDataFormatException: encoded string too > long: 70771 bytes > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java > 1551286 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java > 1551286 > > Diff: https://reviews.apache.org/r/16300/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
