-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16998/#review32738
-----------------------------------------------------------


Minor comment, you fix it after rebasing with OOZIE-1668 patch.


core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/16998/#comment61698>

    We don't need maxNumActionsForLog variable always.
    
    Can you make it static or move it streamLog function( after scope 
verification).
    
    
    
     
    
    



core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java
<https://reviews.apache.org/r/16998/#comment61692>

    fix tab.


- Purshotam Shah


On Jan. 24, 2014, 6:12 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16998/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 6:12 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1671
>     https://issues.apache.org/jira/browse/OOZIE-1671
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1671
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 
>   core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java 
> a29a07e 
>   webapp/src/main/webapp/oozie-console.js 7999d35 
> 
> Diff: https://reviews.apache.org/r/16998/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Reply via email to