> On Feb. 19, 2014, 11:23 p.m., Mona Chitnis wrote: > > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, line 659 > > <https://reviews.apache.org/r/17720/diff/4/?file=484599#file484599line659> > > > > why "revert"? what are we reverting here? change name if possible
i mean by revert that, when enqueue to eventhandler fails, SLACalcStatus is reverted back to original status(EventStatus/SLAStatus), but yes naming is not good, modified. > On Feb. 19, 2014, 11:23 p.m., Mona Chitnis wrote: > > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, line 356 > > <https://reviews.apache.org/r/17720/diff/4/?file=484599#file484599line356> > > > > instead of SLAStatus null here, we could pass IN_PROCESS if null, current SLAstatus of slaCalc (which is IN_PROCESS) is used. > On Feb. 19, 2014, 11:23 p.m., Mona Chitnis wrote: > > core/src/test/java/org/apache/oozie/service/TestHASLAService.java, line 79 > > <https://reviews.apache.org/r/17720/diff/4/?file=484605#file484605line79> > > > > can get slaCalcMem.keyset() directly instead of iterating and setting SLACalculatorMemory doesn't have method to give reference to slaMap, hence using iterate. if I find other testcases use that, I would add it. - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review34939 ----------------------------------------------------------- On Feb. 13, 2014, 9:27 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17720/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 9:27 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1678 > https://issues.apache.org/jira/browse/OOZIE-1678 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1678 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/event/EventQueue.java 39156d6 > core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java f32afb4 > > core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java > e3b115f > > core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java > 79d11ed > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 4207a07 > core/src/main/java/org/apache/oozie/service/JPAService.java aba8709 > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 > core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java a2260a4 > core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 > core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2458e69 > > core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java > 00fb677 > > core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java > 2e170a4 > core/src/test/java/org/apache/oozie/service/TestHASLAService.java > PRE-CREATION > core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 > > Diff: https://reviews.apache.org/r/17720/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
