> On March 3, 2014, 7:24 a.m., Rohini Palaniswamy wrote: > > I like the idea that for a mapreduce action we just exit if there is > > already a job. But can you check if the child job id of the mapreduce job > > is propagated back to the externalChildIds column in the database in that > > case? If not lot of things like stats, etc will be broken.
That would involve the launcher somehow checking the Oozie database (or with the Oozie server to check the OOzie database). And the restart is transparent to the Oozie server, so it can't do anything either. Would it be enough if we checked that the idFile was written to HDFS? (and if not, we can then go and write it, still without killing the child job). > On March 3, 2014, 7:24 a.m., Rohini Palaniswamy wrote: > > hadooplibs/pom.xml, line 38 > > <https://reviews.apache.org/r/18653/diff/2/?file=507592#file507592line38> > > > > Do we need separate modules? Can't we make it part of hadoop-1/0.23/2 > > itself? I am ok either way. I tried that first, but the problem is that we want to pull in the jar with LauncherMainHadoopUtils in it as a compile dependency in the Oozie sharelib, but only want to pull in the hadooplibs as provided. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18653/#review35945 ----------------------------------------------------------- On March 1, 2014, 2:01 a.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18653/ > ----------------------------------------------------------- > > (Updated March 1, 2014, 2:01 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1722 > https://issues.apache.org/jira/browse/OOZIE-1722 > > > Repository: oozie-git > > > Description > ------- > > See https://issues.apache.org/jira/browse/OOZIE-1722 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 68d77a8 > core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > 07de214 > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java b55b9d7 > hadooplibs/hadoop-utils-0.23/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/hadoop-utils-1/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/hadoop-utils-2/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/hadoop-utils-3/pom.xml PRE-CREATION > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > PRE-CREATION > hadooplibs/pom.xml 35875c8 > pom.xml 1223ec2 > sharelib/hive/pom.xml e355d97 > sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > 8fa5ec8 > sharelib/oozie/pom.xml c70582d > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > b5fa4a1 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > 6230e64 > sharelib/pig/pom.xml a2bbeaf > sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 9c1e659 > sharelib/sqoop/pom.xml a962565 > sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > e45c8b2 > > Diff: https://reviews.apache.org/r/18653/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
