----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18995/#review37634 -----------------------------------------------------------
Can we make this part of oozie -change command which modifies the coordinator instead of the rerun command as we are technically not rerunning the job. It will also simplify the code a lot. If -status is specified do not allow other options of the -change command. Also please - add a check to change status to RUNNING only if FAILED or KILLED. Allow only change of status to RUNNING. In future we can add a option for IGNORED status which some users have asking for. - When coordinator is updated, the bundle action also needs to be updated if the parent is a bundle. - Make this a blocking call and retry acquiring lock for up to 2 mins if it cannot be acquired and fail after that. Do not queue the command and return. - Rohini Palaniswamy On March 12, 2014, 11:47 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18995/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 11:47 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1735 > https://issues.apache.org/jira/browse/OOZIE-1735 > > > Repository: oozie-git > > > Description > ------- > > > We should support rerunning of failed job. Job are set to failed if there are > runtime error( like SQL timeout). > In current scenario there is no way to recover beside running SQL. > Rerun should set coord status to running and also set pending to 1 ,reset > doneMaterialization and last modified to current time. So that > materialization continues. > > We should also provide an option of resuming failed action. The behavior will > be same as killed option. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 3c780dd > client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 0466ffe > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 315a330 > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 95f6991 > core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 0693e82 > core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java > 90e205a > > core/src/main/java/org/apache/oozie/command/coord/CoordActionRerunXCommand.java > 301737b > core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > e69de29 > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 240b352 > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 31e9d2f > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 2ef351e > > core/src/test/java/org/apache/oozie/command/coord/TestCoordActionRerunXCommand.java > 3cee71a > > core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java > e69de29 > core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 9c03299 > core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java f3bfc29 > core/src/test/java/org/apache/oozie/test/XDataTestCase.java 317885b > docs/src/site/twiki/DG_CoordinatorRerun.twiki cd593d1 > > Diff: https://reviews.apache.org/r/18995/diff/ > > > Testing > ------- > > ~$ bin/oozie job -rerun 0000000-140311105626214-oozie-puru-C -oozie > http://localhost:11000/oozie > Rerun of coord is successful > ~$ bin/oozie job -rerun 0000000-140311105626214-oozie-puru-C -oozie > http://localhost:11000/oozie > Error: E1018 : E1018: Coord Job Rerun Error: Rerun is only supported for > failed coord > > > Thanks, > > Purshotam Shah > >
