[
https://issues.apache.org/jira/browse/OOZIE-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Kanter updated OOZIE-1734:
---------------------------------
Fix Version/s: (was: 4.0.0)
(was: 3.3.2)
We're not doing any more patches for Oozie 3.x, so I assume
OOZIE-182-bigwheel-GA-4.0.0-v3.patch is the correct patch? In the future,
please name the patch after the JIRA number (e.g. OOZIE-1734.patch or
OOZIE-1734.v1.patch or if there's a different patch for trunk and say Oozie 4,
then OOZIE-1734_branch-4.patch)
I agree that that case should return a 400 instead of 500 in this case.
However, we need to maintain backwards compatibility. So even though 400 makes
more sense here, we shouldn't change the older versions of the REST API (IIRC
changing JsonRestServlet will affect all versions).
I know that v0 and v1 are definitely finalized, but I'm not sure about v2; I
think that might be final since Oozie 4.0.0 was released. This may need to go
in a v3 of the REST API. [~rohini], do you know I'm correct about this?
> Oozie returned 500 Internal Server error when user passes invalid request
> -------------------------------------------------------------------------
>
> Key: OOZIE-1734
> URL: https://issues.apache.org/jira/browse/OOZIE-1734
> Project: Oozie
> Issue Type: Bug
> Components: core
> Affects Versions: 3.3.2, 4.0.0
> Reporter: Chelsey Chang
> Attachments: OOZIE-182-bigwheel-GA-4.0.0-v2.patch,
> OOZIE-182-bigwheel-GA-4.0.0-v3.patch, OOZIE-182-condor-3.3.2-v2.patch,
> OOZIE-182-condor-3.3.2-v3.patch
>
>
> We should return 400 Bad request in this case since its a user error.
> C:\ServiceCode\Main\src>curl -k -g --request PUT -d user.name=hdinsightuser
> -u "<username>:<password>" "<clusterUrl>/oozie/v1/job/?action=kill"
> <html><head><title>Apache Tomcat/6.0.36 - Error report</title><style><!--H1
> {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:22px;}
> H2
> {font-family:Tahoma,Arial,sans
> -serif;color:white;background-color:#525D76;font-size:16px;}
> H3
> {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:14px;}
> BODY
> {font-family:Tahoma,Arial,sans-serif;col or:black;background-color:white;}
> B
> {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;}
> P
> {font-family:Tahoma,Arial,sans-serif;background:white;color:black;font-size:12px;}
> A
> {c olor : black;}
> A.name
> {color : black;}
> HR
> {color : #525D76;}
> --></style> </head><body><h1>HTTP Status 500 - id cannot be empty</h1><HR
> size="1" noshade="noshade"><p><b>type</b> Exception report</p><p><b>
> message</b> <u>id cannot be empty</u></p><p><b>description</b> <u>The server
> encountered an internal error that prevented it from fulfilling this
> request.</u></p><p><b>exception</b> <pre>java.lang.Ill
> egalArgumentException: id cannot be empty
> org.apache.oozie.util.ParamChecker.notEmpty(ParamChecker.java:87)
> org.apache.oozie.util.ParamChecker.notEmpty(ParamChecker.java:71)
> org.apache.oozie.command.coord.CoordKillXCommand.<init>(CoordKillXCommand.java:58)
> org.apache.oozie.CoordinatorEngine.kill(CoordinatorEngine.java:174)
> org.apache.oozie.servlet.V1JobServlet.killCoordinatorJob(V1JobServlet.java:482)
> org.apache.oozie.servlet.V1JobServlet.killJob(V1JobServlet.java:152)
> org.apache.oozie.servlet.BaseJobServlet.doPut(BaseJobServlet.java:97)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:640)
> org.apache.oozie.servlet.JsonRestServlet.service(JsonRestServlet.java:286)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
> org.apache.oozie.servlet.AuthFilter$2.doFilter(AuthFilter.java:126)
> org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:384)
> org.apache.oozie.servlet.AuthFilter.doFilter(AuthFilter.java:131)
> org.apache.oozie.servlet.HostnameFilter.doFilter(HostnameFilter.java:84)
> </pre></p><p><b>note</b> <u>The full stack trace of the root cause is
> available in the Apache Tomcat/6.0.36 logs.</u></p><HR size="1"
> noshade="noshade"><h3>Apache Tomcat/6.0.36</h3></body></html>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
