----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19520/#review41198 -----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/19520/#comment74619> job log filtering options. Please avoid "streaming" in user facing documentation. client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/19520/#comment74621> call the other getJobLog() method. And have method with lesser number of arguments first. core/src/main/java/org/apache/oozie/BundleEngine.java <https://reviews.apache.org/r/19520/#comment74622> Can we add a constructor that takes jobid and also XLogUserFilterParam? Below code is always repeated in lot of places. XLogFilter filter = new XLogFilter(); filter.setParameter(DagXLogInfoService.JOB, jobId); filter.setUserLogFilter(new XLogUserFilterParam(params)); core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java <https://reviews.apache.org/r/19520/#comment74628> There should never be a parse exception from filter.getEndDate(). It should either return a valid date or return null core/src/main/java/org/apache/oozie/util/XLogFilter.java <https://reviews.apache.org/r/19520/#comment74639> return endDate; core/src/main/java/org/apache/oozie/util/XLogFilter.java <https://reviews.apache.org/r/19520/#comment74640> return startDate; core/src/main/java/org/apache/oozie/util/XLogFilter.java <https://reviews.apache.org/r/19520/#comment74638> Add the buffer to jobStartTime and jobEndTime here. core/src/main/java/org/apache/oozie/util/XLogFilter.java <https://reviews.apache.org/r/19520/#comment74641> They can never be null right? core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/19520/#comment74634> Make it private core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/19520/#comment74642> private core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java <https://reviews.apache.org/r/19520/#comment74636> Remove all the setters in this class as they are not required - Rohini Palaniswamy On April 23, 2014, 7:34 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19520/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 7:34 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1737 > https://issues.apache.org/jira/browse/OOZIE-1737 > > > Repository: oozie-git > > > Description > ------- > > User can provide multiple option as -param <>;<>;<> to make streaming faster > and precise. > Option can be. > * Recent: Define offset of recent hours/Min of log to stream. Server will > search user query only in recent log duration. > * Start: Start time of log parsing. Oozie server will start parsing logs > from start date. User can provide a valid date or > offset. > * End: Server will streaming logs till specified end date. User can > provide a valid date or offset. > * Loglevel : Multiple log levels separated by "|" can be specified. > * Text: String to search in logs. > * Limit : Limit number of line to be searched. Log search will end when > when n lines(excluding exception) of patten has > matched. > * Debug : Will print log start and end time. This will be useful, if user > are not sure what his/her offset will be > calculated to. > > > In addition to this > 1. System setting to control log streaming duration. > 2. Added a option to show log streaming status. > A label on UI will show if log streaming is in progress, completed or > erred. > 3. Many user has complied that get button doesn't look like button. Changes > the look of "get log" button. > 4. End the execution when data is date is reached. > earlier started date and end date is only used to load logs files. > ...... > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 9929040 > client/src/main/java/org/apache/oozie/client/OozieClient.java 129579a > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > b0dd6cb > core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538 > core/src/main/java/org/apache/oozie/BundleJobBean.java 4c37e57 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 81d98bf > core/src/main/java/org/apache/oozie/DagEngine.java cad5ddd > core/src/main/java/org/apache/oozie/service/DagXLogInfoService.java 1b18140 > core/src/main/java/org/apache/oozie/service/XLogService.java f9383d0 > core/src/main/java/org/apache/oozie/service/XLogStreamingService.java > f77794e > core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java > 8dc8b4b > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 5b65791 > > core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java > 0a5e8d1 > core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java > 8a11780 > core/src/main/java/org/apache/oozie/util/XLogFilter.java e69de29 > core/src/main/java/org/apache/oozie/util/XLogStreamer.java bc6b009 > core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java e69de29 > core/src/main/resources/oozie-default.xml 47fa0e4 > core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > b4f161a > core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java > c03385d > core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java > 29bca41 > core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 659949f > > core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java > 75341aa > core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java > c2630e7 > core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 8d0fd71 > core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java > e69de29 > core/src/test/resources/userLogFilterTestlog.log e69de29 > docs/src/site/twiki/DG_CommandLineTool.twiki 222389e > docs/src/site/twiki/DG_WorkflowReRun.twiki e6cca80 > docs/src/site/twiki/WebServicesAPI.twiki c93fc7f > webapp/src/main/webapp/oozie-console.js 5f4f847 > > Diff: https://reviews.apache.org/r/19520/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
