----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18754/#review42899 -----------------------------------------------------------
+1 after minor comments sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java <https://reviews.apache.org/r/18754/#comment76829> small nitpick but better to have boolean 'hasPartitions' so that default is true, and in the cache purge case passes new HCatURI(url, false); will also be better condition match elsewhere in HCatURI, e.g. if (hasPartitions) { //do stuff about partitions} sharelib/hcatalog/src/test/java/org/apache/oozie/util/TestHCatURI.java <https://reviews.apache.org/r/18754/#comment76825> typo 'partitions' sharelib/hcatalog/src/test/java/org/apache/oozie/util/TestHCatURI.java <https://reviews.apache.org/r/18754/#comment76824> typo 'partitions' - Mona Chitnis On May 13, 2014, 4:41 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18754/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 4:41 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1492 > https://issues.apache.org/jira/browse/OOZIE-1492 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1492 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8 > > core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 2e5cd47 > > core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java > 6f127c4 > > core/src/main/java/org/apache/oozie/dependency/hcat/HCatDependencyCache.java > df3afd3 > > core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java > e8e3ebc > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > f5304ca > > core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 985dcab > > core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java > da09727 > > core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerService.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > ef71fb0 > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java d797f9b > sharelib/hcatalog/src/test/java/org/apache/oozie/util/TestHCatURI.java > caa2e8c > > Diff: https://reviews.apache.org/r/18754/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
