----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21423/#review42979 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/CoordinatorJobBean.java <https://reviews.apache.org/r/21423/#comment76976> Not familiar with NamedNativeQueries. Most likely needs to be tested with postgres/mysql. core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java <https://reviews.apache.org/r/21423/#comment76964> AbandonedCoordCheckerService. core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java <https://reviews.apache.org/r/21423/#comment76967> email.address core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java <https://reviews.apache.org/r/21423/#comment76965> Coordinators core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java <https://reviews.apache.org/r/21423/#comment76970> failure.limit core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java <https://reviews.apache.org/r/21423/#comment76968> kill.jobs core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java <https://reviews.apache.org/r/21423/#comment76962> CoordToMessage core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java <https://reviews.apache.org/r/21423/#comment76963> Also add oozie base url in the message so that it is clear which server sends it. core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java <https://reviews.apache.org/r/21423/#comment76973> Use a for loop and increment index as status is same. If status is different put status in a array and index for status into the array and do in single for loop to reduce code verbosity. Applicable for other test methods too. - Rohini Palaniswamy On May 14, 2014, 5:12 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21423/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 5:12 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > Report will be sent in html format, where each job is clickable and will take > you to job info. > > Coordinator id > Coordinator name User name Group Kill Status > 0000000-140513184018277-oozie-puru-C COORD-TEST test > testg Coord kill is disabled > 0000001-140513184018277-oozie-puru-C COORD-TEST test > testg Coord kill is disabled > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 7915698 > core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java > 332d02c > core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java cafeaeb > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 1a6ded7 > > core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java > e69de29 > > core/src/test/java/org/apache/oozie/command/coord/TestAbandonedCoordChecker.java > e69de29 > > Diff: https://reviews.apache.org/r/21423/diff/ > > > Testing > ------- > > UTC > > > Thanks, > > Purshotam Shah > >
