[ 
https://issues.apache.org/jira/browse/OOZIE-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000282#comment-14000282
 ] 

Rohini Palaniswamy commented on OOZIE-1783:
-------------------------------------------

[~puru],
   Good point. But cannot expect everyone to have two different sharelibs. Our 
case is different as we don't have sharelibs in a directory but pick from a 
metafile and use the sharelib directory only for shipping launcher libs. In 
other cases they upload only to hdfs once and share it across all servers. 
There was also a jira to keep the old sharelib behavior where the directory has 
no timestamps. So I think we need to take all these cases into account and do 
the fix.

My thought is we should keep the isFirstServer() check and have a different sub 
directory with hostname below oozie.service.WorkflowAppService.system.libpath 
directory (like your suggesstion) under which launcher libs will be shipped (if 
ship launcher is true). sharelib will continue to reside in the top-level of 
libpath directory.  purgeLibs(fs, LAUNCHER_PREFIX, current); can then be done 
outside the isFirstServer() check.

> Sharelib purging only occurs at Oozie startup
> ---------------------------------------------
>
>                 Key: OOZIE-1783
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1783
>             Project: Oozie
>          Issue Type: Bug
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>            Priority: Critical
>         Attachments: OOZIE-1783.patch, OOZIE-1783.patch
>
>
> The purgeLibs method only gets called on startup of the first Oozie server.  
> This means that if you update the sharelib without restarting Oozie, then 
> Oozie will never clean up the old sharelibs and launcherlibs until you 
> restart the server.  In fact, with Oozie HA, it will never clean up unless 
> you restart all of the servers at the same time (in other words, a rolling 
> restart or just restarting one Oozie will never cause purgeLibs to get 
> called).  
> This should be moved into a background thread (i.e. scheduled with 
> SchedulerService) to run periodically.  Once a day is probably good enough, 
> but we could make it configurable if needed.  



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to