> On May 15, 2014, 8:55 p.m., Gilad Wolff wrote: > > core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java, line > > 147 > > <https://reviews.apache.org/r/21278/diff/3/?file=580658#file580658line147> > > > > >= 0 ? what if something takes less than 1ms? > > Robert Kanter wrote: > The reason I added that was that if you add a cron that was never > actually run, without the if statement, you'll add an extra 0 value to the > timer. I'll look into what to do about this.
I've removed that check. The proper usage pattern of the cron object is to run them before adding them. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21278/#review42740 ----------------------------------------------------------- On May 13, 2014, 5:40 p.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21278/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 5:40 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1817 > https://issues.apache.org/jira/browse/OOZIE-1817 > > > Repository: oozie-git > > > Description > ------- > > See > https://issues.apache.org/jira/browse/OOZIE-1817?focusedCommentId=13993838&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13993838 > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 808f9b2 > core/pom.xml c935dd7 > core/src/main/java/org/apache/oozie/command/Command.java d3f1011 > core/src/main/java/org/apache/oozie/command/XCommand.java b712ce0 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > e8667c1 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java > 6962fb2 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 57cbb34 > core/src/main/java/org/apache/oozie/service/InstrumentationService.java > 80437b1 > > core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java > PRE-CREATION > core/src/main/java/org/apache/oozie/service/Services.java 5feac7b > core/src/main/java/org/apache/oozie/service/XLogService.java 403a089 > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 29d7bd6 > core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 5c05acd > core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java 97bd81c > core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java a47f737 > core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java 002a367 > core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/XLogReporter.java PRE-CREATION > core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java > b5206cf > > core/src/test/java/org/apache/oozie/service/TestMetricsInstrumentationService.java > PRE-CREATION > core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 6040b47 > core/src/test/java/org/apache/oozie/util/TestMetricsInstrumentation.java > PRE-CREATION > docs/src/site/twiki/AG_Install.twiki e343d7e > docs/src/site/twiki/WebServicesAPI.twiki 6730255 > pom.xml b5e0e4e > webapp/src/main/webapp/index.jsp 3c7ffe5 > webapp/src/main/webapp/oozie-console.js 764d888 > > Diff: https://reviews.apache.org/r/21278/diff/ > > > Testing > ------- > > Unit tests, also verified in a cluster > > > Thanks, > > Robert Kanter > >
