----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18754/#review44446 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java <https://reviews.apache.org/r/18754/#comment78940> This may not work one because, during put operation whole map is not locked, and while one thread is putting value, other thread's get() call can still return null which result in one thread overriding value inserted by other thread Use putIfAbsent(key, value) core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java <https://reviews.apache.org/r/18754/#comment78841> Can we optimize this function. 2 nested synchronized block, 5 nested loop. This might have performance issue. core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/18754/#comment78840> You can optimize DB query. You can get list of non-waiting action in in DB call. You can use something like. select id from action where id in(?) and status <> WAITING. - Purshotam Shah On May 29, 2014, 9:46 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18754/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 9:46 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1492 > https://issues.apache.org/jira/browse/OOZIE-1492 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1492 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 43d5103 > > core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 2e5cd47 > > core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java > 6f127c4 > > core/src/main/java/org/apache/oozie/dependency/hcat/HCatDependencyCache.java > df3afd3 > > core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java > e8e3ebc > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > f5304ca > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java > 27c97e6 > > core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 985dcab > core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > 611b74c > > core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java > da09727 > > core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerEhCache.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerService.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java > cfdfbd1 > > core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > ef71fb0 > core/src/test/java/org/apache/oozie/test/XTestCase.java 1536927 > core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 > > Diff: https://reviews.apache.org/r/18754/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
