> On July 3, 2014, 6:57 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/service/ZKLocksService.java, line 51 > > <https://reviews.apache.org/r/23245/diff/2/?file=622995#file622995line51> > > > > nitpick: shouldn't this be LEADER_PATH? > > > > Can you also mention this path in the class javadoc comment? > > Robert Kanter wrote: > Also, in the interest of keeping our ZooKeeper namespace clean and well > organized, perhaps we should place this under /services/ (i.e. > /services/locksChildReaperLeader)? Alternatively, if we do OOZIE-1916 first, > then I don't think we need to use the ChildReaper's internal leader-latch.
Actually, I think not using the internal leader-latch may make this more complicated to implement, so let's not do that. But I think /services/locksChildReaperLeader is the right place to put this. Also be sure to update the javadoc in ZKUtils that talks about /services. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23245/#review47308 ----------------------------------------------------------- On July 2, 2014, 8:22 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23245/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 8:22 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1906 > https://issues.apache.org/jira/browse/OOZIE-1906 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1906 Service to periodically remove ZK lock > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/ZKLocksService.java d03a899 > core/src/main/resources/oozie-default.xml 982c82f > core/src/test/java/org/apache/oozie/service/TestZKLocksService.java a773469 > pom.xml bad1e0f > > Diff: https://reviews.apache.org/r/23245/diff/ > > > Testing > ------- > > UTC and manual testing. > > > Thanks, > > Purshotam Shah > >
