----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23223/#review47399 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/23223/#comment83129> You need to have separate LOG object per EventWorker and can't reuse the EventHandlerService's LOG. Will have conflicts with multi threading. core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java <https://reviews.apache.org/r/23223/#comment83130> setLogPrefix() core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java <https://reviews.apache.org/r/23223/#comment83131> Actually for this object you don't have to reset and set again. Can be just done once in the constructor as id and appname will never change. core/src/main/java/org/apache/oozie/util/LogUtils.java <https://reviews.apache.org/r/23223/#comment83132> setLogPrefix(). Just for consistent naming everywhere. - Rohini Palaniswamy On July 3, 2014, 12:41 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23223/ > ----------------------------------------------------------- > > (Updated July 3, 2014, 12:41 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1911 > https://issues.apache.org/jira/browse/OOZIE-1911 > > > Repository: oozie-git > > > Description > ------- > > See JIRA Description from link above > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 4207a07 > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java f148db3 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 47c723d > core/src/main/java/org/apache/oozie/util/LogUtils.java fd5b5b6 > core/src/test/java/org/apache/oozie/service/TestHASLAService.java eec5369 > > Diff: https://reviews.apache.org/r/23223/diff/ > > > Testing > ------- > > new unit test + existing tests pass > > > Thanks, > > Mona Chitnis > >
