-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23301/
-----------------------------------------------------------
(Updated July 25, 2014, 8 a.m.)
Review request for oozie.
Changes
-------
This patch added getting rid of duplicated code in ActionStartXCommand.
Throws ActionExecutorException if ELEvaluate or parsing fail. This
ActionExecutorException is handled as following FAILED case.
Bugs: OOZIE-1918
https://issues.apache.org/jira/browse/OOZIE-1918
Repository: oozie-git
Description
-------
Subclasses of ActionXCommand have some duplicated code. Refactoring make it
more neat.
This patch contain:
* Renaming CompletedActionXCommand to ActionCompletedXCommand and extending
ActionXCommand
* Moving some variables and methods to ActionXCommand and making it protected
* More meaningful log message : On exeucte(), actionId is duplicated so removed
* Adding handleExecutionFail() to handle ActionExcutionException during
execute()
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/DagEngine.java f6e5b4f
core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java
39c522d
core/src/main/java/org/apache/oozie/command/wf/ActionCompletedXCommand.java
PRE-CREATION
core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 42cb290
core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java
863bf7d
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java
f3a4ba9
core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548
core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java
41e6732
Diff: https://reviews.apache.org/r/23301/diff/
Testing
-------
No added new testcase.
Done manual test.
Thanks,
Azrael Park
