----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23968/#review49586 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/CallableQueueService.java <https://reviews.apache.org/r/23968/#comment86820> We don't need to call callable.setLogInfo() as the data wouldn't be loaded at this point. Just XLog.Info.get().clear() will be enough core/src/main/java/org/apache/oozie/service/CallableQueueService.java <https://reviews.apache.org/r/23968/#comment86821> Don't need afterExecute() core/src/main/java/org/apache/oozie/util/XLog.java <https://reviews.apache.org/r/23968/#comment86826> Instead of calling createPrefix() for every log(), we can call createPrefix() in LogUtils.setLogInfo() which stores prefix. log() can just get this prefix - shwethags On Aug. 5, 2014, 7:49 a.m., Azrael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23968/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 7:49 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1939 > https://issues.apache.org/jira/browse/OOZIE-1939 > > > Repository: oozie-git > > > Description > ------- > > Because of ThreadLocal, I added setLogInfo() at XCommand. > If the logInfo in setLogInfo() is enough, It might not need to set logInfo in > loadState(). > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 94b55cf > core/src/main/java/org/apache/oozie/command/XCommand.java 44e1133 > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > 41ad8ae > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java > 8ccab0e > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java > 65eb272 > core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java > c101f45 > core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java > 0a04a02 > core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java > f5f4b3f > core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java > 74fbcab > > core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > ffb2d08 > > core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java > 5d6ef65 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 9ac66b2 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 0a9e4fa > > core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java > 562b211 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java > ffe85f0 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java > c774f8e > > core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1ca055d > > core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 5a5bf98 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 6e3af70 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionsIgnoreXCommand.java > ed85a40 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java > d2b4659 > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > a2748c4 > core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 91e9e09 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > b4b2fef > core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java > cc2127a > > core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > ae71924 > core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 735b295 > core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java > 0aae1e6 > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 02b30ef > core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > b1b2fcd > core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java > a177101 > core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java > d6e47da > core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 39c522d > core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 42cb290 > core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > 863bf7d > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > f3a4ba9 > core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 0c4c548 > core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java > 41e6732 > core/src/main/java/org/apache/oozie/command/wf/DefinitionXCommand.java > 64d4822 > core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 37a2f8b > core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java > 651b5fd > core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 5dd06ca > core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 7b8ee3b > core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 4a7283f > core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java > 5e9abcf > core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 66baca1 > core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 635186a > core/src/main/java/org/apache/oozie/service/CallableQueueService.java > 093eb08 > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 761537b > core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca > core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java f7458dc > core/src/main/java/org/apache/oozie/util/LogUtils.java 814caff > core/src/main/java/org/apache/oozie/util/XLog.java 31a5ba0 > core/src/test/java/org/apache/oozie/util/TestXLog.java 824e5dc > > Diff: https://reviews.apache.org/r/23968/diff/ > > > Testing > ------- > > Done manual test. > > > Thanks, > > Azrael Park > >
