----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24187/#review49867 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/24187/#comment87270> This will break if someone has same env key repeated twice in map.env or am.env (the hadoop behavior that caused problem with the current issue was to support those cases). For eg: PATH It should be Map<String, List<String>> instead of Map<String, String> - Rohini Palaniswamy On Aug. 6, 2014, 9:52 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24187/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 9:52 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1958 > https://issues.apache.org/jira/browse/OOZIE-1958 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1958?filter=-1 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 94b55cf > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 72a137c > > Diff: https://reviews.apache.org/r/24187/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
