[ 
https://issues.apache.org/jira/browse/OOZIE-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110072#comment-14110072
 ] 

Hadoop QA commented on OOZIE-1945:
----------------------------------

Testing JIRA OOZIE-1945

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 
132
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:red}-1 COMPILE{color}
.    {color:red}-1{color} HEAD does not compile
.    {color:red}-1{color} patch does not compile
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:red}-1 DISTRO{color}
.    {color:red}-1{color} distro tarball fails with the patch

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1695/

> NPE in JaveActionExecutor#check()
> ---------------------------------
>
>                 Key: OOZIE-1945
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1945
>             Project: Oozie
>          Issue Type: Bug
>    Affects Versions: trunk
>            Reporter: Mona Chitnis
>            Priority: Trivial
>             Fix For: trunk, 4.1.0
>
>         Attachments: OOZIE-1945-patch.3, oozie-1945-patch-2, 
> oozie-1945.patch.1
>
>
> in method check()
> {code}
>  String errorCode = props.getProperty("error.code");
>                             if (errorCode.equals("0")) {
>                                 errorCode = "JA018";
>                             }
>                             if (errorCode.equals("-1")) {
>                                 errorCode = "JA019";
>                             }
>                             errorReason = props.getProperty("error.reason");
> {code}
> if error.code is null, these leads to NPEs
> easy fix
> {code}
> if ("0".equals(errorCode))
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to