----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25066/#review51908 -----------------------------------------------------------
Ship it! Assuming the e2e tests pass, LGTM. Can you also add the missing @Override I mentioned? - Robert Kanter On Aug. 26, 2014, 11:32 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25066/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 11:32 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1728 > https://issues.apache.org/jira/browse/OOZIE-1728 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1728 > > > Diffs > ----- > > core/pom.xml 5b2eedc > core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > fe31d7b > > core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java > PRE-CREATION > core/src/test/java/org/apache/oozie/action/hadoop/TestDistcpMain.java > PRE-CREATION > sharelib/distcp/pom.xml 04e436d > > sharelib/distcp/src/main/java/org/apache/oozie/action/hadoop/DistcpMain.java > PRE-CREATION > > sharelib/distcp/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java > b075957 > > Diff: https://reviews.apache.org/r/25066/diff/ > > > Testing > ------- > > upload patch for review, doing e2e test now. > > > Thanks, > > Ryota Egashira > >
