> On Sept. 9, 2014, 3:12 p.m., Mona Chitnis wrote: > > core/src/main/java/org/apache/oozie/command/bundle/BundleStatusTransitXCommand.java, > > line 81 > > <https://reviews.apache.org/r/24948/diff/1/?file=668667#file668667line81> > > > > But this is executed only if condition bAction.getCoordId() == null. So > > the case you mention will not occur
It will. "condition bAction.getCoordId() == null" means that one of bundle coord submit has failed and we need to kill bundle job. > On Sept. 9, 2014, 3:12 p.m., Mona Chitnis wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordStatusTransitXCommand.java, > > line 168 > > <https://reviews.apache.org/r/24948/diff/1/?file=668668#file668668line168> > > > > Then I think we should 'skip' loading in SKIPPED actions from DB. The > > idea of skipped is that its outcome would not make any difference. So if > > all other actions are terminal, you will mark parent coord/bundle as > > terminal. if some are non-terminal, it wont be. ok to optimize this from > > earlier code It make difference. Assume there are 3 coord actions. 1. failed. 2. Skipped 3. Skipped. Current behavior, final status will be DONEWITHERROR. If I skip "Skipped" action then, final status will be failed. Same with killed. I think it's ok to not change existing behavior. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24948/#review52722 ----------------------------------------------------------- On Sept. 8, 2014, 9:15 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24948/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 9:15 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1940 > https://issues.apache.org/jira/browse/OOZIE-1940 > > > Repository: oozie-git > > > Description > ------- > > StatusTransitService has race condition > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/BundleActionBean.java 5d85a4d > core/src/main/java/org/apache/oozie/BundleJobBean.java 0f1670a > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 795bf63 > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 8fd53f1 > core/src/main/java/org/apache/oozie/ErrorCode.java 88a2c67 > core/src/main/java/org/apache/oozie/command/StatusTransitXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleStatusTransitXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordStatusTransitXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java > 36cd968 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > 3008393 > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 04e6e29 > core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 21ac25f > core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java > bb99138 > > Diff: https://reviews.apache.org/r/24948/diff/ > > > Testing > ------- > > UTC > > > Thanks, > > Purshotam Shah > >
